[FFmpeg-cvslog] avcodec: Add NVENC encoder

Jean-Baptiste Kempf jb at videolan.org
Thu Dec 11 01:54:38 CET 2014


On 11 Dec, Timo Rothenpieler wrote :
> +#if defined(_WIN32) && !defined(__CYGWIN__)
> +#include <windows.h>
> +#else
> +#include <dlfcn.h>
> +#endif
> +
> +/* NVENC API is stdcall in cygwin, as it's still Windows */
> +#if defined(__CYGWIN__) && !defined(_WIN32)
> +#define _WIN32
> +#define TEMP_WIN32
> +#endif
> +
> +#include <nvEncodeAPI.h>
> +
> +#if defined(TEMP_WIN32)
> +#undef _WIN32
> +#endif

How can you commit such things?
Defining symbols starting with "_" + uppercase ? This is a violation of the C
standards.

Cygwin is very able to use windows.h functions. If not, it's their mess,
but this has nothing to do here.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the ffmpeg-cvslog mailing list