[FFmpeg-cvslog] lavfi/frei0r: load plugins from lib64 folders as well on 64bit builds

Michael Niedermayer michael at niedermayer.cc
Fri Feb 14 05:01:22 CET 2014


On Tue, Feb 11, 2014 at 07:17:19AM +0100, Reimar Döffinger wrote:
> 
> 
> On 11.02.2014, at 03:44, git at videolan.org (Marton Balint) wrote:
> 
> > ffmpeg | branch: master | Marton Balint <cus at passwd.hu> | Wed Feb  5 01:24:19 2014 +0100| [8e41240047db2571a4752fb23c3e6907b16d1e88] | committer: Michael Niedermayer
> > 
> > lavfi/frei0r: load plugins from lib64 folders as well on 64bit builds
> > 
> > Signed-off-by: Marton Balint <cus at passwd.hu>
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8e41240047db2571a4752fb23c3e6907b16d1e88
> > ---
> > 
> > libavfilter/vf_frei0r.c |   12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> > 
> > diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c
> > index a070eb4..c5922fd 100644
> > --- a/libavfilter/vf_frei0r.c
> > +++ b/libavfilter/vf_frei0r.c
> > @@ -284,6 +284,18 @@ static av_cold int frei0r_init(AVFilterContext *ctx,
> >         if (ret < 0)
> >             return ret;
> >     }
> > +#if ARCH_X86_64
> 
> This makes no sense IMO, there are tons of other 64 bit architectures, why should this only be done for x86?!
> We have a define for 64 bit in general, but honestly I see little reason to make it conditional at all (also just having a path list would be nicer than duplicating the code for each path to check).

CCing the author

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20140214/88a5a2fa/attachment.asc>


More information about the ffmpeg-cvslog mailing list