[FFmpeg-cvslog] avformat/wavenc: Check umid length

Michael Niedermayer git at videolan.org
Sun May 10 20:12:17 CEST 2015


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun May 10 19:54:41 2015 +0200| [004564c930ef60d2f9e8798e820ed7b2a37ba0bd] | committer: Michael Niedermayer

avformat/wavenc: Check umid length

Fixes potential out of array read

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=004564c930ef60d2f9e8798e820ed7b2a37ba0bd
---

 libavformat/wavenc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
index baadd91..74b5d56 100644
--- a/libavformat/wavenc.c
+++ b/libavformat/wavenc.c
@@ -120,7 +120,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
     avio_wl64(s->pb, time_reference);
     avio_wl16(s->pb, 1);  // set version to 1
 
-    if (tmp_tag = av_dict_get(s->metadata, "umid", NULL, 0)) {
+    if ((tmp_tag = av_dict_get(s->metadata, "umid", NULL, 0)) && strlen(tmp_tag->value) > 2) {
         unsigned char umidpart_str[17] = {0};
         int64_t i;
         uint64_t umidpart;



More information about the ffmpeg-cvslog mailing list