[FFmpeg-cvslog] avcodec/flacdsp_template: Fix undefined shift in flac_decorrelate_indep_c

Michael Niedermayer git at videolan.org
Sat Dec 3 18:32:20 EET 2016


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sat Dec  3 16:43:10 2016 +0100| [acc163c6ab52d2235767852262c64c7f6b273d1c] | committer: Michael Niedermayer

avcodec/flacdsp_template: Fix undefined shift in flac_decorrelate_indep_c

Fixes: left shift of negative value
Fixes: 668346-media

Found-by: Matt Wolenetz <wolenetz at google.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=acc163c6ab52d2235767852262c64c7f6b273d1c
---

 libavcodec/flacdsp_template.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/flacdsp_template.c b/libavcodec/flacdsp_template.c
index 62c0a15..776c78d 100644
--- a/libavcodec/flacdsp_template.c
+++ b/libavcodec/flacdsp_template.c
@@ -56,7 +56,7 @@ static void FUNC(flac_decorrelate_indep_c)(uint8_t **out, int32_t **in,
 
     for (j = 0; j < len; j++)
         for (i = 0; i < channels; i++)
-            S(samples, i, j) = in[i][j] << shift;
+            S(samples, i, j) = (int)((unsigned)in[i][j] << shift);
 }
 
 static void FUNC(flac_decorrelate_ls_c)(uint8_t **out, int32_t **in,



More information about the ffmpeg-cvslog mailing list