[FFmpeg-cvslog] ffprobe: only use custom logging callback if -show_log is set

Marton Balint git at videolan.org
Wed Apr 12 22:24:44 EEST 2017


ffmpeg | branch: release/3.3 | Marton Balint <cus at passwd.hu> | Wed Apr  5 20:17:48 2017 +0200| [69e35db80d0f066aff401390afbf114a027d7817] | committer: Marton Balint

ffprobe: only use custom logging callback if -show_log is set

The custom callback can cause significant CPU usage on Windows for some large
files with many index entries for some reason.

v2: Move check after parsing options.

Signed-off-by: Marton Balint <cus at passwd.hu>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=69e35db80d0f066aff401390afbf114a027d7817
---

 ffprobe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/ffprobe.c b/ffprobe.c
index 356746870e..a219fc10b0 100644
--- a/ffprobe.c
+++ b/ffprobe.c
@@ -3442,8 +3442,6 @@ int main(int argc, char **argv)
         goto end;
     }
 #endif
-    av_log_set_callback(log_callback);
-
     av_log_set_flags(AV_LOG_SKIP_REPEATED);
     register_exit(ffprobe_cleanup);
 
@@ -3459,6 +3457,9 @@ int main(int argc, char **argv)
     show_banner(argc, argv, options);
     parse_options(NULL, argc, argv, options, opt_input_file);
 
+    if (do_show_log)
+        av_log_set_callback(log_callback);
+
     /* mark things to show, based on -show_entries */
     SET_DO_SHOW(CHAPTERS, chapters);
     SET_DO_SHOW(ERROR, error);



More information about the ffmpeg-cvslog mailing list