[FFmpeg-cvslog] avcodec/aacdec_fixed: Fix undefined shift

Michael Niedermayer git at videolan.org
Fri Dec 8 11:34:32 EET 2017


ffmpeg | branch: release/3.4 | Michael Niedermayer <michael at niedermayer.cc> | Sun Nov  5 21:20:07 2017 +0100| [db82e4f1e059056a591f9b143c26ea3de7c5e308] | committer: Michael Niedermayer

avcodec/aacdec_fixed: Fix undefined shift

Fixes: runtime error: left shift of negative value -801112064
Fixes: 3492/clusterfuzz-testcase-minimized-5784775283441664

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit fca198fb5bf42ba6b765b3f75b11738e4b4fc2a9)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=db82e4f1e059056a591f9b143c26ea3de7c5e308
---

 libavcodec/aacdec_fixed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c
index d802f3834f..32bd1454bd 100644
--- a/libavcodec/aacdec_fixed.c
+++ b/libavcodec/aacdec_fixed.c
@@ -309,7 +309,7 @@ static av_always_inline void predict(PredictorState *ps, int *coef,
             if (shift > 0) {
                 *coef += (unsigned)((pv.mant + (1 << (shift - 1))) >> shift);
             } else
-                *coef += (unsigned)(pv.mant << -shift);
+                *coef += (unsigned)pv.mant << -shift;
         }
     }
 



More information about the ffmpeg-cvslog mailing list