[FFmpeg-cvslog] lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr

Matt Wolenetz git at videolan.org
Wed Feb 8 22:11:23 EET 2017


ffmpeg | branch: release/3.0 | Matt Wolenetz <wolenetz at google.com> | Wed Dec 14 15:24:42 2016 -0800| [4f7064c9da35cd8156f6aee4a25e9b4e7f4ae607] | committer: Michael Niedermayer

lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr

Core of patch is from paul at paulmehta.com
Reference https://crbug.com/643950

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
Check value reduced as the code does not support larger lengths

(cherry picked from commit fd30e4d57fe5841385f845440688505b88c0f4a9)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4f7064c9da35cd8156f6aee4a25e9b4e7f4ae607
---

 libavformat/mov.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6b90d08..e6b6c67 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -674,6 +674,8 @@ static int mov_read_hdlr(MOVContext *c, AVIOContext *pb, MOVAtom atom)
 
     title_size = atom.size - 24;
     if (title_size > 0) {
+        if (title_size > FFMIN(INT_MAX, SIZE_MAX-1))
+            return AVERROR_INVALIDDATA;
         title_str = av_malloc(title_size + 1); /* Add null terminator */
         if (!title_str)
             return AVERROR(ENOMEM);



More information about the ffmpeg-cvslog mailing list