[FFmpeg-cvslog] avcodec/bsf: fix resource leak in av_bsf_list_parse_str

Steven Liu git at videolan.org
Tue Jan 10 22:11:19 EET 2017


ffmpeg | branch: master | Steven Liu <lq at chinaffmpeg.org> | Wed Jan 11 04:09:47 2017 +0800| [d9c2cfd31675a6403ae4ac7c141a8185dadceb12] | committer: Steven Liu

avcodec/bsf: fix resource leak in av_bsf_list_parse_str

cid: 1396268
when av_strdup(str) error, the lst need release

Reviewed-by: James Almer <jamrial at gmail.com>
Signed-off-by: Steven Liu <lq at chinaffmpeg.org>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d9c2cfd31675a6403ae4ac7c141a8185dadceb12
---

 libavcodec/bsf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
index ac2024b..c984526 100644
--- a/libavcodec/bsf.c
+++ b/libavcodec/bsf.c
@@ -514,8 +514,10 @@ int av_bsf_list_parse_str(const char *str, AVBSFContext **bsf_lst)
     if (!lst)
         return AVERROR(ENOMEM);
 
-    if (!(dup = buf = av_strdup(str)))
-        return AVERROR(ENOMEM);
+    if (!(dup = buf = av_strdup(str))) {
+        ret = AVERROR(ENOMEM);
+        goto end;
+    }
 
     while (1) {
         bsf_str = av_strtok(buf, ",", &saveptr);



More information about the ffmpeg-cvslog mailing list