[FFmpeg-cvslog] Revert "x86/sbrdsp: remove unnecessary sign extend instruction in apply_noise_main"

James Almer git at videolan.org
Wed Jul 5 16:33:25 EEST 2017


ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Wed Jul  5 10:28:03 2017 -0300| [9d5e81d3b160cd6688a6c382e816d4b7db071f66] | committer: James Almer

Revert "x86/sbrdsp: remove unnecessary sign extend instruction in apply_noise_main"

This reverts commit 24bb7db4037876c5722b0eecf7412502e7225634.

noise has to after all be sign extended, not zero extended, on tests
other than checkasm.
Fixes most aac tests broken by the now reverted commit.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9d5e81d3b160cd6688a6c382e816d4b7db071f66
---

 libavcodec/x86/sbrdsp.asm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm
index 51680f048b..62bbe512ec 100644
--- a/libavcodec/x86/sbrdsp.asm
+++ b/libavcodec/x86/sbrdsp.asm
@@ -382,7 +382,8 @@ apply_noise_main:
 %else
     DEFINE_ARGS Y, s_m, q_filt, noise, kx, count
 %endif
-    dec    noised
+    movsxdifnidn    noiseq, noised
+    dec    noiseq
     shl    countd, 2
 %ifdef PIC
     lea NOISE_TABLE, [sbr_noise_table]



More information about the ffmpeg-cvslog mailing list