[FFmpeg-cvslog] checkasm: Read the unsigned value as it should

Luca Barbato git at videolan.org
Mon Mar 20 12:56:42 EET 2017


ffmpeg | branch: master | Luca Barbato <lu_zero at gentoo.org> | Sun Sep 11 01:14:37 2016 +0200| [e89cef40506d990a982aefedfde7d3ca4f88c524] | committer: Luca Barbato

checkasm: Read the unsigned value as it should

Reading a value larger than int using atoi() may give the wrong result.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e89cef40506d990a982aefedfde7d3ca4f88c524
---

 tests/checkasm/checkasm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 86d3bab..5b4aa64 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -477,7 +477,8 @@ static void print_cpu_name(void)
 
 int main(int argc, char *argv[])
 {
-    int i, seed, ret = 0;
+    unsigned int seed;
+    int i, ret = 0;
 
 #if ARCH_ARM && HAVE_ARMV5TE_EXTERNAL
     if (have_vfp(av_get_cpu_flags()) || have_neon(av_get_cpu_flags()))
@@ -504,7 +505,7 @@ int main(int argc, char *argv[])
         argv++;
     }
 
-    seed = (argc > 1) ? atoi(argv[1]) : av_get_random_seed();
+    seed = (argc > 1) ? strtoul(argv[1], NULL, 10) : av_get_random_seed();
     fprintf(stderr, "checkasm: using random seed %u\n", seed);
     av_lfg_init(&checkasm_lfg, seed);
 



More information about the ffmpeg-cvslog mailing list