[FFmpeg-cvslog] avcodec/fic: Avoid some magic numbers related to cursors

Michael Niedermayer git at videolan.org
Tue Jul 10 12:05:36 EEST 2018


ffmpeg | branch: release/2.8 | Michael Niedermayer <michael at niedermayer.cc> | Sat May  5 23:42:36 2018 +0200| [f98794c73a7f90da43e06126e60a7bbda530fba7] | committer: Michael Niedermayer

avcodec/fic: Avoid some magic numbers related to cursors

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit c6a11714c4b1227be62cbc36651ccfc415e8e623)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f98794c73a7f90da43e06126e60a7bbda530fba7
---

 libavcodec/fic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/fic.c b/libavcodec/fic.c
index 7bfb998a55..14887d94a0 100644
--- a/libavcodec/fic.c
+++ b/libavcodec/fic.c
@@ -81,6 +81,7 @@ static const uint8_t fic_qmat_lq[64] = {
 static const uint8_t fic_header[7] = { 0, 0, 1, 'F', 'I', 'C', 'V' };
 
 #define FIC_HEADER_SIZE 27
+#define CURSOR_OFFSET 59
 
 static av_always_inline void fic_idct(int16_t *blk, int step, int shift, int rnd)
 {
@@ -417,7 +418,7 @@ static int fic_decode_frame(AVCodecContext *avctx, void *data,
 
     /* Draw cursor. */
     if (!skip_cursor) {
-        memcpy(ctx->cursor_buf, src + 59, 32 * 32 * 4);
+        memcpy(ctx->cursor_buf, src + CURSOR_OFFSET, sizeof(ctx->cursor_buf));
         fic_draw_cursor(avctx, cur_x, cur_y);
     }
 



More information about the ffmpeg-cvslog mailing list