[FFmpeg-cvslog] configure: Drop unnecessary variables, shifts, and quotes in helper functions

Diego Biurrun git at videolan.org
Fri Mar 16 00:47:27 EET 2018


ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Sat Oct 21 01:27:23 2017 +0200| [8c893aa3cd5f2d73896c72af330dcbfe299fbc5a] | committer: Diego Biurrun

configure: Drop unnecessary variables, shifts, and quotes in helper functions

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8c893aa3cd5f2d73896c72af330dcbfe299fbc5a
---

 configure | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/configure b/configure
index d882d4c73f..f373698b6c 100755
--- a/configure
+++ b/configure
@@ -816,7 +816,7 @@ EOF
 
 check_insn(){
     log check_insn "$@"
-    check_inline_asm ${1}_inline "\"$2\""
+    check_inline_asm ${1}_inline "$2"
     echo "$2" | check_as && enable ${1}_external || disable ${1}_external
 }
 
@@ -1097,11 +1097,9 @@ check_struct(){
 check_builtin(){
     log check_builtin "$@"
     name=$1
-    headers=$2
-    builtin=$3
-    shift 3
+    shift
     disable "$name"
-    check_code ld "$headers" "$builtin" "$@" && enable "$name"
+    check_code ld "$@" && enable "$name"
 }
 
 check_compile_assert(){
@@ -1118,25 +1116,20 @@ require(){
     log require "$@"
     name_version="$1"
     name="${1%% *}"
-    headers="$2"
-    func="$3"
-    shift 3
-    check_lib $name "$headers" $func "$@" || die "ERROR: $name_version not found"
+    shift
+    check_lib $name "$@" || die "ERROR: $name_version not found"
 }
 
 require_header(){
     log require_header "$@"
     headers="$1"
-    shift
-    check_header "$headers" "$@" || die "ERROR: $headers not found"
+    check_header "$@" || die "ERROR: $headers not found"
 }
 
 require_cpp_condition(){
     log require_cpp_condition "$@"
-    header="$1"
     condition="$2"
-    shift 2
-    check_cpp_condition "$header" "$condition" "$@" || die "ERROR: $condition not satisfied"
+    check_cpp_condition "$@" || die "ERROR: $condition not satisfied"
 }
 
 require_pkg_config(){



More information about the ffmpeg-cvslog mailing list