[FFmpeg-cvslog] avformat/apetag: tag values are unsigned

Dan Sanders git at videolan.org
Fri Apr 19 19:25:52 EEST 2019


ffmpeg | branch: master | Dan Sanders <sandersd at google.com> | Thu Apr 18 17:12:14 2019 -0700| [fac761dae92791af3d1ae05479e423fc9a8e7704] | committer: James Almer

avformat/apetag: tag values are unsigned

Fixes: UBSan runtime error
Found-by: Clusterfuzz
Reviewed-by: Michael Niedermayer <michael at niedermayer.cc>
Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=fac761dae92791af3d1ae05479e423fc9a8e7704
---

 libavformat/apetag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/apetag.c b/libavformat/apetag.c
index cdc602e1a9..8cb3f4a23a 100644
--- a/libavformat/apetag.c
+++ b/libavformat/apetag.c
@@ -29,7 +29,7 @@
 #include "apetag.h"
 #include "internal.h"
 
-#define APE_TAG_FLAG_CONTAINS_HEADER  (1 << 31)
+#define APE_TAG_FLAG_CONTAINS_HEADER  (1U << 31)
 #define APE_TAG_FLAG_LACKS_FOOTER     (1 << 30)
 #define APE_TAG_FLAG_IS_HEADER        (1 << 29)
 #define APE_TAG_FLAG_IS_BINARY        (1 << 1)



More information about the ffmpeg-cvslog mailing list