[FFmpeg-cvslog] avcodec/dstdec: Fix integer overflow in read_table()

Michael Niedermayer git at videolan.org
Sat May 2 19:52:44 EEST 2020


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun Feb  9 00:23:14 2020 +0100| [2d465a401dd790e2ca126ecb9cbda43f898a492f] | committer: Michael Niedermayer

avcodec/dstdec: Fix integer overflow in read_table()

Fixes: signed integer overflow: -16 * 134217879 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5639509530378240

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2d465a401dd790e2ca126ecb9cbda43f898a492f
---

 libavcodec/dstdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c
index bdabced823..9feca4b085 100644
--- a/libavcodec/dstdec.c
+++ b/libavcodec/dstdec.c
@@ -156,7 +156,7 @@ static int read_table(GetBitContext *gb, Table *t, const int8_t code_pred_coeff[
             for (j = method + 1; j < t->length[i]; j++) {
                 int c, x = 0;
                 for (k = 0; k < method + 1; k++)
-                    x += code_pred_coeff[method][k] * t->coeff[i][j - k - 1];
+                    x += code_pred_coeff[method][k] * (unsigned)t->coeff[i][j - k - 1];
                 c = get_sr_golomb_dst(gb, lsb_size);
                 if (x >= 0)
                     c -= (x + 4) / 8;



More information about the ffmpeg-cvslog mailing list