[FFmpeg-cvslog] avformat/vorbiscomment: Don't compute strlen twice
Andreas Rheinhardt
git at videolan.org
Fri Aug 27 12:36:39 EEST 2021
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Mon Aug 23 07:52:54 2021 +0200| [64020dfe08f7f2212571a2c2ef10ea366a492a95] | committer: Andreas Rheinhardt
avformat/vorbiscomment: Don't compute strlen twice
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=64020dfe08f7f2212571a2c2ef10ea366a492a95
---
libavformat/vorbiscomment.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/vorbiscomment.c b/libavformat/vorbiscomment.c
index a929634cc0..13ee065a44 100644
--- a/libavformat/vorbiscomment.c
+++ b/libavformat/vorbiscomment.c
@@ -66,9 +66,10 @@ int ff_vorbiscomment_write(AVIOContext *pb, const AVDictionary *m,
const char *vendor_string,
AVChapter **chapters, unsigned int nb_chapters)
{
+ size_t vendor_string_length = strlen(vendor_string);
int cm_count = 0;
- avio_wl32(pb, strlen(vendor_string));
- avio_write(pb, vendor_string, strlen(vendor_string));
+ avio_wl32(pb, vendor_string_length);
+ avio_write(pb, vendor_string, vendor_string_length);
if (chapters && nb_chapters) {
for (int i = 0; i < nb_chapters; i++) {
cm_count += av_dict_count(chapters[i]->metadata) + 1;
More information about the ffmpeg-cvslog
mailing list