[FFmpeg-cvslog] lavc/videotoolboxenc: explicitly set realtime=false
rcombs
git at videolan.org
Thu Dec 23 02:45:27 EET 2021
ffmpeg | branch: master | rcombs <rcombs at rcombs.me> | Sat Dec 18 14:39:19 2021 -0600| [4778ab2b1fa993457bb3657de56a12dc9a55f3a0] | committer: rcombs
lavc/videotoolboxenc: explicitly set realtime=false
On some encoders, this defaults to true, which can result in encode speed
being _limited_ to only slightly above realtime (as a power-saving measure),
so we need a way to disable it.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4778ab2b1fa993457bb3657de56a12dc9a55f3a0
---
libavcodec/videotoolboxenc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index a2f5aa9be9..418ff00b8d 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -1389,10 +1389,10 @@ static int vtenc_create_encoder(AVCodecContext *avctx,
}
}
- if (vtctx->realtime) {
+ if (vtctx->realtime >= 0) {
status = VTSessionSetProperty(vtctx->session,
compat_keys.kVTCompressionPropertyKey_RealTime,
- kCFBooleanTrue);
+ vtctx->realtime ? kCFBooleanTrue : kCFBooleanFalse);
if (status) {
av_log(avctx, AV_LOG_ERROR, "Error setting realtime property: %d\n", status);
@@ -2677,7 +2677,7 @@ static const enum AVPixelFormat prores_pix_fmts[] = {
{ "require_sw", "Require software encoding", OFFSET(require_sw), AV_OPT_TYPE_BOOL, \
{ .i64 = 0 }, 0, 1, VE }, \
{ "realtime", "Hint that encoding should happen in real-time if not faster (e.g. capturing from camera).", \
- OFFSET(realtime), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, \
+ OFFSET(realtime), AV_OPT_TYPE_BOOL, { .i64 = 0 }, -1, 1, VE }, \
{ "frames_before", "Other frames will come before the frames in this session. This helps smooth concatenation issues.", \
OFFSET(frames_before), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, \
{ "frames_after", "Other frames will come after the frames in this session. This helps smooth concatenation issues.", \
More information about the ffmpeg-cvslog
mailing list