[FFmpeg-cvslog] ffbuild: Avoid using the --preprocessor argument to windres

Martin Storsjö git at videolan.org
Fri Jun 18 11:19:33 EEST 2021

ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Sat May 15 00:42:38 2021 +0300| [f9626d1065c43f1d51afe66bdf988b9f33729440] | committer: Martin Storsjö

ffbuild: Avoid using the --preprocessor argument to windres

Instead use --preprocessor-arg; in binutils 2.36, the --preprocessor
flag was changed so that it no longer accepts a string containing
multiple arguments, but the whole --preprocessor argument is
treated as the path to the preprocessor executable (where the path
can contain spaces).

It's currently unclear whether this behaviour will stay or if it
is going to be reverted in the future, see discussion at [1]. Just
to be safe, avoid using the --preprocessor argument. Don't redeclare
the full preprocessing command, but just add the $(CC_DEPFLAGS) options.

Based on a patch by Kyle Schwartz.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=27594

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f9626d1065c43f1d51afe66bdf988b9f33729440

 configure          | 1 -
 ffbuild/common.mak | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index 6bfd98b384..87c8e85fe6 100755
--- a/configure
+++ b/configure
@@ -7535,7 +7535,6 @@ LD_LIB=$LD_LIB
diff --git a/ffbuild/common.mak b/ffbuild/common.mak
index 32f5b997b5..5d8f3dfc1f 100644
--- a/ffbuild/common.mak
+++ b/ffbuild/common.mak
@@ -90,7 +90,7 @@ COMPILE_MSA = $(call COMPILE,CC,MSAFLAGS)
 %.o: %.rc
-	$(WINDRES) $(IFLAGS) --preprocessor "$(DEPWINDRES) -E -xc-header -DRC_INVOKED $(CC_DEPFLAGS)" -o $@ $<
+	$(WINDRES) $(IFLAGS) $(foreach ARG,$(CC_DEPFLAGS),--preprocessor-arg "$(ARG)") -o $@ $<
 %.i: %.c
 	$(CC) $(CCFLAGS) $(CC_E) $<

More information about the ffmpeg-cvslog mailing list