[FFmpeg-cvslog] avformat/hlsenc: Remove nonsense memset

Andreas Rheinhardt git at videolan.org
Thu Nov 18 07:27:11 EET 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Tue Nov  9 20:42:35 2021 +0100| [7596b6530d5f00ea0510b5c698714c76369811e7] | committer: Andreas Rheinhardt

avformat/hlsenc: Remove nonsense memset

The memset here is both unnecessary (avio_read() ignores the previous
content of the destination buffer) as well as nonsense (for a char
buf[BUFSIZE] sizeof(buf) and sizeof(BUFSIZE) are not the same; the
latter is sizeof(int)).
Fixes Coverity issue #1465863.

Reviewed-by: Steven Liu <lq at chinaffmpeg.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7596b6530d5f00ea0510b5c698714c76369811e7
---

 libavformat/hlsenc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 98608a834a..557cf1bee3 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -2382,7 +2382,6 @@ static int64_t append_single_file(AVFormatContext *s, VariantStream *vs)
     }
 
     do {
-        memset(buf, 0, sizeof(BUFSIZE));
         read_byte = avio_read(vs->out, buf, BUFSIZE);
         avio_write(vs->out_single_file, buf, read_byte);
         if (read_byte > 0) {



More information about the ffmpeg-cvslog mailing list