[FFmpeg-cvslog] avformat/utils: Remove unused shorthand feature for auto-inserted BSF

Andreas Rheinhardt git at videolan.org
Thu Nov 18 07:27:19 EET 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Mon Nov  8 15:03:52 2021 +0100| [419d93c379bb6834529ec7e65a18ce4982c864aa] | committer: Andreas Rheinhardt

avformat/utils: Remove unused shorthand feature for auto-inserted BSF

Besides being unused it should not be used at all:
The order of options of bitstream filters is not guaranteed
to be stable at all.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=419d93c379bb6834529ec7e65a18ce4982c864aa
---

 libavformat/utils.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index a8611f5877..6eac3f721e 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -1800,13 +1800,7 @@ int ff_stream_add_bitstream_filter(AVStream *st, const char *name, const char *a
     }
 
     if (args && bsfc->filter->priv_class) {
-        const AVOption *opt = av_opt_next(bsfc->priv_data, NULL);
-        const char * shorthand[2] = {NULL};
-
-        if (opt)
-            shorthand[0] = opt->name;
-
-        if ((ret = av_opt_set_from_string(bsfc->priv_data, args, shorthand, "=", ":")) < 0) {
+        if ((ret = av_set_options_string(bsfc->priv_data, args, "=", ":")) < 0) {
             av_bsf_free(&bsfc);
             return ret;
         }



More information about the ffmpeg-cvslog mailing list