[FFmpeg-cvslog] seek: Fix crashes in ff_seek_frame_binary if built with latest Clang 14

Martin Storsjö git at videolan.org
Mon Oct 18 14:44:14 EEST 2021

ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Mon Oct 18 12:31:38 2021 +0300| [ab792634197e364ca1bb194f9abe36836e42f12d] | committer: Martin Storsjö

seek: Fix crashes in ff_seek_frame_binary if built with latest Clang 14

Passing an uninitialized variable as argument to a function is
undefined behaviour (UB). The compiler can assume that UB does not

Hence, the compiler can assume that the variables are never
uninitialized when passed as argument, which means that the codepaths
that initializes them must be taken.

In ff_seek_frame_binary, this means that the compiler can assume
that the codepaths that initialize pos_min and pos_max are taken,
which means that the conditions "if (sti->index_entries)" and
"if (index >= 0)" can be optimized out.

Current Clang git versions (upcoming Clang 14) enabled an optimization
that does this, which broke the current version of this function
(which intentionally left the variables uninitialized, but silencing
warnings about being uninitialized). See [1] for discussion on
the matter.

[1] https://reviews.llvm.org/D105169#3069555

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ab792634197e364ca1bb194f9abe36836e42f12d

 libavformat/seek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/seek.c b/libavformat/seek.c
index 40169736df..405ca316b3 100644
--- a/libavformat/seek.c
+++ b/libavformat/seek.c
@@ -283,7 +283,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int stream_index,
                          int64_t target_ts, int flags)
     const AVInputFormat *const avif = s->iformat;
-    int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit;
+    int64_t pos_min = 0, pos_max = 0, pos, pos_limit;
     int64_t ts_min, ts_max, ts;
     int index;
     int64_t ret;

More information about the ffmpeg-cvslog mailing list