[FFmpeg-cvslog] avfilter/af_afir: fix some misc low priority issues

Paul B Mahol git at videolan.org
Mon Dec 19 00:49:17 EET 2022


ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Sun Dec 18 23:50:24 2022 +0100| [a350e68c83cfc9b24d4476c6c17cfbdf86b3d8d1] | committer: Paul B Mahol

avfilter/af_afir: fix some misc low priority issues

Remove double ;; and dead store.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a350e68c83cfc9b24d4476c6c17cfbdf86b3d8d1
---

 libavfilter/af_afir.c       | 2 +-
 libavfilter/afir_template.c | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/libavfilter/af_afir.c b/libavfilter/af_afir.c
index dfbc9d7cf1..bfb27e07d9 100644
--- a/libavfilter/af_afir.c
+++ b/libavfilter/af_afir.c
@@ -136,7 +136,7 @@ static int fir_channels(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
 static int fir_frame(AudioFIRContext *s, AVFrame *in, AVFilterLink *outlink)
 {
     AVFilterContext *ctx = outlink->src;
-    AVFrame *out = NULL;
+    AVFrame *out;
 
     out = ff_get_audio_buffer(outlink, in->nb_samples);
     if (!out) {
diff --git a/libavfilter/afir_template.c b/libavfilter/afir_template.c
index 821be95785..e5eae4b3e2 100644
--- a/libavfilter/afir_template.c
+++ b/libavfilter/afir_template.c
@@ -331,7 +331,7 @@ static int fn(fir_quantum)(AVFilterContext *ctx, AVFrame *out, int ch, int offse
         const int part_size = seg->part_size;
         int j;
 
-        seg->part_index[ch] = seg->part_index[ch] % nb_partitions;;
+        seg->part_index[ch] = seg->part_index[ch] % nb_partitions;
         if (min_part_size >= 8) {
 #if DEPTH == 32
             s->fdsp->vector_fmul_scalar(src + input_offset, in, dry_gain, FFALIGN(nb_samples, 4));
@@ -359,7 +359,7 @@ static int fn(fir_quantum)(AVFilterContext *ctx, AVFrame *out, int ch, int offse
         memset(sumin, 0, sizeof(*sumin) * seg->fft_length);
         blockin = (ftype *)seg->blockin->extended_data[ch] + seg->part_index[ch] * seg->block_size;
         blockout = (ftype *)seg->blockout->extended_data[ch] + seg->part_index[ch] * seg->block_size;
-        memset(blockin + part_size, 0, sizeof(*blockin) * (seg->fft_length - part_size));
+        memset(blockin + part_size, 0, sizeof(*blockin) * (seg->block_size - part_size));
         memcpy(blockin, src, sizeof(*src) * part_size);
 
         seg->tx_fn(seg->tx[ch], blockout, blockin, sizeof(ftype));
@@ -398,8 +398,6 @@ static int fn(fir_quantum)(AVFilterContext *ctx, AVFrame *out, int ch, int offse
         fn(fir_fadd)(s, buf, sumout, part_size);
 
         memcpy(dst, buf, part_size * sizeof(*dst));
-
-        buf = (ftype *)seg->buffer->extended_data[ch];
         memcpy(buf, sumout + part_size, part_size * sizeof(*buf));
 
         seg->part_index[ch] = (seg->part_index[ch] + 1) % nb_partitions;



More information about the ffmpeg-cvslog mailing list