[Ffmpeg-devel] [PATCH] from DivX, Part 8: bitstream assert

Steve Lhomme slhomme
Sat Dec 17 00:59:20 CET 2005


This patch adds some assert() in the bitstream reader. That should avoid 
silly bugs like the ones I'm going to send next (reading more bits than 
available).

I know this was discussed before, assert() in C is meant to be used by 
developpers to stop when a mandatory condition is not met in the code. 
This allows and ensures errors are handled in the code. And thus that it 
doesn't crash on the user. (all the crashes in DrDivX OSS are now due to 
problems in FFMPEG).

So please, when you develop make sure the assert() is on, that will save 
a lot of time later.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bitstream-assert.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20051216/ed54fb5a/attachment.asc>



More information about the ffmpeg-devel mailing list