[Ffmpeg-devel] Patch for dynamic liba52.so loading
Sat Jun 11 04:17:29 CEST 2005
On Fri, Jun 10, 2005 at 06:44:47PM +0200, August Mayer wrote:
> It seems that the code for dynamically loading liba52.so (CONFIG_AC3 &&
> CONFIG_A52BIN) has been rotting for some time. There are two problems in
> 1. It uses fprintf instead of av_log, and
> 2. libavcodec/parser.c directly links to a52_syncinfo, which is not
> available as a global symbol in this case.
> I've corrected these two problems; attached are the patches for it.
> Moreover, I have changed the code so that the references and function
> pointers are stored in static variables instead of the AVCodecContext.
> This looks more sensible to me, because liba52 only needs to be loaded
> once during program lifetime. Is it possible that there are multiple
> codec contexts? If so, then liba52.so would have been loaded multiple times.
Of course there are multiple codec contexts. Is there a good reason
for dynamic loading support? IMO it's unnecessary complexity that
should just be removed..
More information about the ffmpeg-devel