[Ffmpeg-devel] [PATCH] update libavformat support for CONFIG_ENCODERS

Michael Niedermayer michaelni
Tue May 10 03:45:28 CEST 2005


Hi

On Monday 09 May 2005 21:14, Roine Gustafsson wrote:
> On May 9, 2005, at 7:09 PM, Michael Niedermayer wrote:
> > On Monday 09 May 2005 18:48, Roine Gustafsson wrote:
> >> This adds nearly full support for CONFIG_ENCODERS to libavformat. If
> >> libavformat is compiled without CONFIG_ENCODERS most of the muxers
> >> will
> >> not be compiled in.
> >> It mostly adds #ifdef's, but sometimes needs to add static to
> >> functions
> >> so they are not compiled in if not referenced. (This generates some
> >> warnings though).
> >
> > rejected, CONFIG_ENCODERS has nothing to do with (de)muxers, muxers and
> > encoders are independant ...
>
> I'm just continuing what was already present - grep for CONFIG_ENCODERS
> in lavf and you'll see.

i know and i dont like it


> I agree the name CONFIG_ENCODERS is not appropriate; do you want to
> change it?

i would prefer a #define per (de)muxer but renaming is acceptable too, just 
the CONFIG_ENCODERS which is used in lavc cannot be used for a different 
purpose in lavf

[...]
-- 
Michael





More information about the ffmpeg-devel mailing list