[Ffmpeg-devel] [PATCH]ogg flac

[Måns Rullgård]

matthieu castet <castet.matthieu at free.fr> writes:

> Hi,
>
> this patch add support to ogg flac in ffmpeg.

> -OBJS+= ogg.o
> +#OBJS+= ogg.o

ogg.c is still needed for ogg writing.

>     static int header_number = 0;

Don't do that.  Consider a file with more than one flac stream, or
reading more than one file with flac audio.

>     if (os->seq > header_number)
>         return 0;
>
>     /* XXX parse other headers ... */
>     if (header_number)
> 	    return 1;

Why don't you look at the first byte of the packet instead?
Non-header packets should start with 0xff.

-- 
M?ns Rullg?rd
mru at inprovide.com