[Ffmpeg-devel] [PATCH]ogg flac

[Måns Rullgård]

matthieu castet <castet.matthieu at free.fr> writes:

> Hi,
>
> M?ns Rullg?rd wrote:
>> matthieu castet <castet.matthieu at free.fr> writes:
>>
>>>matthieu castet wrote:
>>>
>>>>Hi,
>>>>this patch add support to ogg flac in ffmpeg.
>>>>
>>>
>>>opps the first patch was bugous (tabs + an error in the makefile).
>> There's still a static variable in there.
>>
>
> This patch fix the static variable problem.
> I also add the comment parsing.
>
> Matthieu
>
> PS : shouldn't we add a id for flac in codec_wav_tags, if we want to
> transcode flac in another format ?

Is there one in common use?

>     int *header_number = os->private;
>
>     if (!os->private)
>         os->private = header_number = av_mallocz(sizeof(int));
>
>     if (os->seq > *header_number)
>         return 0;

Why don't you just examine the first byte of the packet?  This is
better for two reasons: 1) it's simpler, and 2) the header number is
allowed to be zero, in which case this will break.

-- 
M?ns Rullg?rd
mru at inprovide.com