[Ffmpeg-devel] [PATCH] different vorbis extradata handling

Michael Niedermayer michaelni
Fri May 13 01:07:57 CEST 2005


On Friday 13 May 2005 00:56, M?ns Rullg?rd wrote:
> Nico Sabbi <nsabbi at tiscali.it> writes:
> > Hi,
> > following yesterday's discussion about the management of vorbis extradata
> > I patched oggvorbis.c, matroska.c and oggparsevorbis.c to follow
> > matroska's model.
> > Note: there's a xiphlacing() function duplicated in ogg*.c  as
> > file-static, because
> > I don't know where it should stay. If you tell me where I will update
> > the patch.
> ogg2.c seems like good place to me.  You should also get rid of all
> the useless casts.

no single (de)muxer or codec is a good place for a function used by several, 
codecs&(de)muxers should be relatively independant so omitting some is not 
too tricky


More information about the ffmpeg-devel mailing list