[Ffmpeg-devel] [PATCH] different vorbis extradata handling

Måns Rullgård mru
Fri May 13 22:05:12 CEST 2005


Nico Sabbi <nsabbi at tiscali.it> writes:

> matthieu castet wrote:
>
>>>
>> Don't you should falback on the old method if the header is wrong ?
>> All vorbis saved in nut, ... won't be playable anymore...
>>
>> Shouldn't you do the same thing for theora ?
>> And for flac ?
>>
>>
>> Matthieu
>
> here's the fallback patch.
> Successfully testes on all avi samples, but I could never generate
> working nut samples: everytime
> ffmpeg crashes with FPEs.
>
> Ok to commit?

I'd much rather do it by checking the first two bytes.  It should be
perfectly fail-safe.

-- 
M?ns Rullg?rd
mru at inprovide.com





More information about the ffmpeg-devel mailing list