[Ffmpeg-devel] [PATCH] Vorbis fix
Thu May 19 22:07:36 CEST 2005
On Thursday 19 May 2005 21:16, Rich Felker wrote:
> On Thu, May 19, 2005 at 10:34:47AM +0200, Milan Cutka wrote:
> > > Hopefully this patch corrects the decoding.
> > Thanks. It works now.
> > Attached patch decreases vorbis decoder stack usage. This is needed when
> > used vorbis decoder in ffdshow which runs in thread created by the player
> > application, sometimes with quite low stack size.
> If windows is this broken, ffdshow needs to allocate its own stack
> before calling libavcodec. We should not design libavcodec around
> broken platforms with miniscule stack, especially if it may affect
> performance (malloc/free on every frame is not acceptable, it will
> lead to horrible memory fragmentation and likely bad cache
AFAIK this array is just needed during init, and ive replaced other large
arrays on the stack with malloced() ones in libav* in the past
we could stop working around these issues but i have the feeling that would
break a few more platforms then just windows, especially embeded ones i would
so ill apply such a patch if Balatoni Denes (vorbis decoder author) says its
More information about the ffmpeg-devel