[Ffmpeg-devel] Re: [PATCH] RTP/RTSP and MPEG4-AAC audio (Repost)

[Romain DEGEZ]

Michael Niedermayer wrote:
> Hi
> 

Hi

>>+RTPPayloadType_t RTPPayloadTypes[]=
> 
> 
> global variables need a prefix to avoid name clashes, RTP is certainly not 
> libav* specific enough

I added 'AV' prefix, is it ok ?

>>+static inline uint16_t decode_be16(const uint8_t *p) 
>>+{   
>>+    return (p[0] << 8) | p[1];
>>+}  
> 
> 
> BE_16()

done.

> the patch contains tabs

Fixed (I Hope :-)

> the propose of comments is to provide information which isnt obvious from the 
> code

Sure, removed some unnecessary comment.

> the whole extra_infos system is unaceptable its significantly too complicated 
> and messy
> the string id from an attribute is looked up in the attr_names table converted 
> to a integer send into rtp_set_int/str_attribute() which then practically 
> converts the integer into the point in a codec specific structure (void 
> *extra_infos) where the int or char* argument is stored (not surprisingly you 
> forget to free a few things which got allocated on the way)
> just store the values in a single codec independant structure

I changed the way to store the values. Do you prefer this way ?

Please comment

-- 
Romain DEGEZ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp.c.patch
Type: text/x-patch
Size: 18579 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050523/0387a5c2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp.h.patch
Type: text/x-patch
Size: 3576 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050523/0387a5c2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp.c.patch
Type: text/x-patch
Size: 13439 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050523/0387a5c2/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp.h.patch
Type: text/x-patch
Size: 496 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050523/0387a5c2/attachment-0003.bin>