[Ffmpeg-devel] Re: [PATCH] RTP/RTSP and MPEG4-AAC audio (Repost)
Wed May 25 18:29:11 CEST 2005
Romain DEGEZ wrote:
> Michael Niedermayer wrote:
>>>I changed the way to store the values. Do you prefer this way ?
>>yes, but its still more complicated then needed, more precisely
>>SDP_FMTP_ENTRY__* is unneeded, attr_names could contain the offsets of the
>>rtp_payload_data_t structure fields where each entry should be stored
> I'm not sure of having understood what you said :-)
> Do you prefer this way ? (use of offsetof() to fill the attr_names map).
Just one quick comment:
RTP payload types 96 and up are *always* dynamic payload types.
So why have all of them in a static table? Why not just have
the code check for payload type >= 96, and deal with the dynamic
payload types that way?
Just a suggestion,
More information about the ffmpeg-devel