[Ffmpeg-devel] [PATCH] cook compatible decoder
Fri Nov 4 14:57:38 CET 2005
On Fri, Nov 04, 2005 at 02:04:04PM +0100, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> >On Fri, Nov 04, 2005 at 11:29:25AM +0100, Benjamin Larsson wrote:
> >> [...]
> >>I think a swap is needed, I just don't know the order.
> >> obuf[i] = le2me_32(0x37c511f2^buf[i]);
> >another issue here is that at least buf might not be 32bit aligned (if
> >sub_packet_size %4 != 0 if i understand it correctly)
> >i guess a simple if(sub_packet_size %4) return -1 would be the correct
> >solution? or does such a size make sense?
> IIRC firstrun.rm has a sub_packet_size of 93, so it needs to be handled.
> Currently all sub_packets are stored in an unaligned manner if the
> is not evenly divided by 4. Is 32bit alignment mandated?
if its accessed by a 32bit int then yes, otherwise it wont work on many non
x86 architectures, some (ARM IIRC) will even give wrong results silently
More information about the ffmpeg-devel