[Ffmpeg-devel] [PATCH] Add DESTDIR support to Makefiles

İsmail Dönmez ismail
Tue Oct 18 19:18:20 CEST 2005


On Tuesday 18 October 2005 14:12, Diego Biurrun wrote:
> On Tue, Oct 18, 2005 at 12:55:56PM +0200, Diego Biurrun wrote:
> > On Tue, Oct 18, 2005 at 11:31:22AM +0300, ?smail D?nmez wrote:
> > > On Monday 17 October 2005 10:53, Fran?ois Revol wrote:
> > > > > smail D?nmez wrote:
> > > > > > Following patch adds DESTDIR support so you can do :
> > > > > >
> > > > > > make install # Normal install to /
> > > > > > make DESTDIR=/home/cartman/ffmpeg install # Install
> > > > > > under /home/cartman/ffmpeg/usr etc
> > > > > >
> > > > > > DESTDIR is a must for packaging. Also note that this patch
> > > > > > doesn't affect any functionality so it works as expected.
> > > > > >
> > > > > > Please comment/review/apply :)
> > > > >
> > > > > 	Isn't this the kind of thing that usually belongs in the configure
> > > > > script?
> > > >
> > > > No, it's one of the few really handy real features of autoconf based
> > > > things (those done right, many fail to support that), so that you can
> > > > install where you want, while configuring elsewhere.
> > > > Very useful when used in a bigger project.
> > >
> > > So can we please apply this patch or tell me if there is anything wrong
> > > with it with respect to whitespace or something?
> >
> > Samuel Hocevar achieves the same effect with the following (much
> > simpler) patch in his Debian packages.
> >
> > Sam, what do you say?  I'm tempted to apply your patch.
>
> ... and here is the patch ...
>
> Diego

Nope that doesn't look correct to me. It looks like just doing 
--prefix=$DESTDKR which is not the point of the patch. Are the produced *.pc 
files are showing correct path with Debian's patch? I very much doubt so. 
Also my way is the current accepted way to implement DESTDIR support in make 
based projects. Which imho is a plus.

Regards,
ismail





More information about the ffmpeg-devel mailing list