[Ffmpeg-devel] [RFC] More PCM formats (was: [PATCH] demuxer for dcinema audio)

[Michael Niedermayer]

Hi

On Fri, Sep 02, 2005 at 11:18:56AM +0200, Reimar D?ffinger wrote:
> Hi,
> On Fri, Sep 02, 2005 at 01:02:36AM +0200, Michael Niedermayer wrote:
> > please use 4 space indention / keep indention consistant within each file
> 
> Right. I'm so used to using 2 spaces it's hard to do it differently.
> 
> > > +    (*dst)[1 - le] = v & 0xff;
> > 
> > isnt the & 0xff redundant here?
> 
> Yes, missed the fact that the destination was only one byte big anyway *g*
> 
> > [...]
> > > +            for (i = 0; i < 16; i++) {
> > > +              tmp2 <<= 1;
> > > +              tmp2 |= (tmp & 1);
> > > +              tmp >>= 1;
> > > +            }
> > 
> > should be ff_reverse[tmp>>8] + (ff_reverse[tmp&0xFF]<<8)
> 
> Wow. Nice. And fast. Though including bistream.h looks a bit weird.
> Thanks for all the help, it really looks a lot nicer than the first
> version. Is it close to being acceptable now?

yes, feel free to apply it

[...]

-- 
Michael