[Ffmpeg-devel] [PATCH] introduce swscale interface inlibavcodec

Luca Abeni lucabe72
Thu Apr 6 13:44:18 CEST 2006


Hi Michael,

On Thu, 2006-04-06 at 01:36 +0200, Michael Niedermayer wrote:
[...] 
> > Now, the problem is how to do the import in practice.
> > Here is my proposal:
> > step 1: import the postproc subdir "as is" from mplayer. I think a
> > person with admin powers can do this preserving the history (at least, I
> > seem to remember seeing an admin moving a directory from a CVS
> > repository to another without loosing the history... But I do not know
> > what he did. Maybe he just copied all the *,v files?)
> 
> yes, its that simple ...
Good. One problem less :)

> > step 2: apply a cosmetic mega-patch removing all tabs and trailing
> > whitespaces from the imported directory (is this needed?)
> 
> yes
Ok; I am working on it

> > step 3: apply libswscale.diff so that swscale is compilable in the
> > ffmpeg tree
> > step 4: apply the "configure and Makefile" part of the ffmpeg patch
> > (I'll split the patch), so that swscale compilation can be actually
> > enabled
> > step 5: apply the padding/cropping patchset, after I re-reviewed it (I
> > want to be really sure that it does not create troubles).
> > 
> > Does this sound like a good plan? Has anyone alternative ideas?
> 
> sounds ok, i or attila will take care of step 1 as soon as the other things
> seem to have reached "applyable" state
Ok, good. I think I have most of the patches ready. I just need to
recheck them, to be sure that I did not mess up something with the last
changes.

> also dont forget mplayer, it should stay compileable too :)
> though breakage for a short time (a few hours) isnt a problem and might
> happen due to murphies law anyway with such a big move
Ugh... I was sure I was forgetting something :)
I think mplayer will need two changes:
1) a small change in the configuration/build mechanism to link swscale
from the new location (in ffmpeg tree). BTW, does it make sense to
compile mplayer without swscale? (Just asking, because I do not know
mplayer internals)
2) a change to all the swscale callers, to use ffmpeg pixel format names
instead of the VO ones that are currently used. Maybe some #define trick
will help.
I think I'll need some help from mplayers developers...

Would it be acceptable to initially import swscale in ffmpeg (without
removing it from mplayer), and remove the postproc subdirectory from
mplayer's repository in a second time, after mplayer will properly
support swscale from ffmpeg? (obviously, the interval between these two
times will not be too long).


			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !





More information about the ffmpeg-devel mailing list