[Ffmpeg-devel] [PATCH] grabbing with V4L

Flavio Pimentel Duarte flaviop
Mon Apr 17 19:15:15 CEST 2006


Hi Luca,
    after more than one month our changes to grab.c were not applied, 
even your changes in ffmpeg.c to fallback to v4l was not applied. Since 
I did not see a message rejecting our changes, I am assuming it is in a 
todo list.
Can you tell me if our changes will be applied or it will be lost ?

Fl?vio

Luca Abeni wrote:

>Hi Flavio,
>
>On Thu, 2006-02-23 at 08:54 -0300, Flavio Pimentel Duarte wrote:
>[...]
>  
>
>>>Can you try the attached patch?
>>>      
>>>
>> 	It did not work at first try. But it was not your patch's 
>>fault. I had to change v4l2.c. In open_device function, it did not close 
>>the device after an error detection. I am sending the changes I had to do 
>>in an attached patch.
>>    
>>
>Ehhh... Still a bug of mine. Thanks for finding the problem.
>Yes, these two "close()" are missing in v4l2.c. This patch needs to be
>committed.
>Maybe some other error path forgets to close the file... I am out of
>town right now, but on Monday I'll check the error paths in v4l2.c and
>I'll submit a more complete patch if needed.
>
>			Thanks,
>				Luca
>
> 
> 
> --
> Email.it, the professional e-mail, gratis per te: http://www.email.it/f
> 
> Sponsor:
> Cartucce, toner, ricariche...scegli a chi rivolgerti per la tua stampante. Clicca qui
> Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4198&d=24-2
>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel at mplayerhq.hu
>http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>  
>





More information about the ffmpeg-devel mailing list