[Ffmpeg-devel] MPEG2 seeking broken

Rodrigo Severo rodrigo
Wed Apr 19 22:26:26 CEST 2006


On 4/19/06, Steve Lhomme <steve.lhomme at free.fr> wrote:
> Rodrigo Severo wrote:
> > On 4/19/06, Mike Melanson <mike at multimedia.cx> wrote:
> >> Michael Niedermayer wrote:
> >>>> +    assert(ref_picture != NULL);
> >>>> +    if (ref_picture == NULL) {
> >>>
> >>> is not acceptable
> >> What's the policy? No asserts?
> >
> >
> > I believe I can answer this one:
> >
> > You asserted that ref_picture != NULL and them creates some condition to
> > execute in case ref_picture is NULL. It won't ever be executed.
>
> One is designed to catch the error during debugging, the other is
> designed to not crash in "release" builds. Crashing a user software when
> you know there's a potential problem is gross.

Yeah, I thought that could be so. This is the risk of answering
without seeing the whole code.

Let's hear from Michael.


Rodrigo





More information about the ffmpeg-devel mailing list