[Ffmpeg-devel] [PATCH] Fix buffer overflows in vorbis.c

Roberto Togni r_togni
Sun Apr 23 22:39:30 CEST 2006


On Fri, 21 Apr 2006 17:20:40 +0300
Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:

> If the Vorbis file has a huge number of audio channels the output packet
> size might exceed AVCODEC_MAX_AUDIO_FRAME_SIZE. The code allocates
> buffers that need to be big enough for blocksize_0 and blocksize_1 based
> on the value of blocksize_1, but allows bitstream to specify blocksize_0
> larger than blocksize_1. Patch adds checks against these conditions.

Looks ok to me, and vorbis.c have no maintainer.
If nobody comments i'll apply it soon.

Ciao,
 Roberto





More information about the ffmpeg-devel mailing list