[Ffmpeg-devel] [PATCH] conditionally build parts of lavc

[Diego Biurrun]

On Thu, Aug 03, 2006 at 10:23:40PM +0100, M?ns Rullg?rd wrote:
> M?ns Rullg?rd <mru at inprovide.com> writes:
> 
> > M?ns Rullg?rd <mru at inprovide.com> writes:
> >
> >> Here's a patch that lets parts of lavc and lavf be built only if some
> >> enabled codec needs them.  The dependencies may need to be adjusted a
> >> little, and some code could be moved between files to make it work
> >> better, but this should be good for an initial review.
> >>
> >> Please test and comment.
> >
> > Updated for current svn.
> 
> Forgot to include a new file in the diff.
> 
> --- configure	(revision 5924)
> +++ configure	(working copy)
> @@ -2077,10 +2078,16 @@
>  
> +for codec in $DECODER_LIST $ENCODER_LIST $PARSER_LIST $DEMUXER_LIST $MUXER_LIST; do

While you're at it, please rename the loop variable to something more
fitting than "codec"; part, component, line, thingy, whatever..

> --- libavcodec/i386/dsputil_mmx.c	(revision 5924)
> +++ libavcodec/i386/dsputil_mmx.c	(working copy)
> @@ -2522,6 +2524,7 @@
>  
> +#ifdef CONFIG_ENCODERS
>  static int try_8x8basis_mmx(int16_t rem[64], int16_t weight[64], int16_t basis[64], int scale){

All of these are not strictly related to this patch, commit them right
away separately..

> --- libavcodec/Makefile	(revision 5924)
> +++ libavcodec/Makefile	(working copy)
> @@ -8,21 +8,31 @@
>  
> +OBJS= utils.o allcodecs.o \
> +      resample.o resample2.o \
> +      imgconvert.o imgresample.o \
> +      parser.o \
>        opt.o \
>        bitstream_filter.o \

I'd say put these on a line of their own while you're at it...

> @@ -204,16 +222,19 @@
>  
> -OBJS-$(CONFIG_FAAD)                    += faad.o
> +OBJS-$(CONFIG_AAC_DECODER)             += faad.o

Why these and similar - arguably cosmetic - changes?

> --- confdeps.mak	(revision 0)
> +++ confdeps.mak	(revision 0)
> @@ -0,0 +1,352 @@
> +
> +or = $(if $(findstring $(1),$(foreach v,$(2),$($(v)))),echo $@,false)

This line could use a comment..

I'm not sure I'm terribly happy with this patch.  I feel it could be
simplified still, but I'm not sure how to do it right now.

Also it's currently broken, 'sh -v -x configure' reveals the following
endless loop:

+ read conf
+ echo '#define y 1'
+ echo y=yes

Diego