[Ffmpeg-devel] [PATCH] '/nop' illegal for old versions of GAS

[Michael Niedermayer]

Hi
On Mon, Aug 07, 2006 at 12:00:48PM +0200, Michael Niedermayer wrote:
[...]
> > 	If modifying the macro to remove the rounding ability
> > is OK, then this all becomes easy - just comment it out:
> > 
> > -        #rounder ", %%mm4               \n\t"\
> > +        /* #rounder ", %%mm4            \n\t" Add a rounding constant 
> > */\
> 
> sorry no, i summarize it again
> NOP must be a macro defined by #define
> the output of the code must not change
> the code must be clean, the patch must conform to whats described in our
> docs
> theres nothing tricky with that its a plain and simple change
> 
> you dont seem to know how the c preprocessor works, and you dont seem to
> be willing to learn it / read the manual thats fine but then you dont
> qualify as contributor, as knowledge of the language or at least will to
> read the manuals is required to contribute to a project which is written
> in that language, again,
> i dont need mac intel support, if someone wants it he has to do the work
> 
> also note that if the trolling about macintel continues
> (trolling here means repeatly sending patches and proposing things which ive
> said already are not ok) then ill ban thouse who send such spam, as it
> confuses others into thinking that someone would be working on macintel
> support while we are actually just playing with a troll who never intended
> to send a useable patch but instead is trying to cause as much work for us
> as possible, again the patch submitter must do the work not we, this is true
> for every patch. alternatives are not possible for a project of the size of
> ffmpeg, we simply cannot rewrite everything people submit

after reading my own post again it seems ive been a little more harsh then
intended, so sorry but what you proposed is not ok,

just replacing 
code like:
ROW_IDCT(  64(%0), 72(%0), 80(%0), 88(%0), 64(%1), paddd (%2), 11)
with:
ROW_IDCT(  64(%0), 72(%0), 80(%0), 88(%0), 64(%1), "paddd (%2)", 11)

together with the other changes i proposed will work
and is IMO nothing special but just normal use of the pre processor

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is