[Ffmpeg-devel] [PATCH] fix snow x86 SIMD

Michael Niedermayer michaelni
Tue Aug 8 11:00:28 CEST 2006


On Tue, Aug 08, 2006 at 01:14:27AM +0200, Luca Barbato wrote:
> Michael Niedermayer wrote:
> > 
> > if REG_b is not on the clobber list then you cannot clobber it, for example
> > it might be used in a "m"  or a "r" 
> > 
> http://bugs.gentoo.org/show_bug.cgi?id=142380#c36
> http://bugs.gentoo.org/attachment.cgi?id=93696
> Some updates about it.

> @@ -15,7 +15,11 @@
>  #  define PTR_SIZE "8"
>  #else
>  #  define REG_a "eax"
> +# ifdef PIC
> +#  define REG_b "ebp"
> +# else
>  #  define REG_b "ebx"
> +# endif
>  #  define REG_c "ecx"
>  #  define REG_d "edx"
>  #  define REG_D "edi"

sorry, no, every patch you submit gets dirtier then the previous, either
cleanly change the code or leave it
REG_b IS ebx, and alot of code will break if you change this, every use of
ebp, "b", "m", REG_BP, REGb, ... at least, and not only that but its 
conceptually wrong,  its like "#define PI sqrt(2)"

additionally, id suggest that you run the regression tests before sumitting
patches, (i think ill ignore every asm related PIC fix if the author doesnt
explicitly say that the regression tests passed)


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list