[Ffmpeg-devel] [PATCH] Incorrect memset in Sierra decoder

Kostya kostya.shishkov
Wed Aug 9 08:11:30 CEST 2006


On Tue, Aug 08, 2006 at 07:29:49PM +0200, Diego Biurrun wrote:
> On Tue, Aug 08, 2006 at 12:50:16PM +0200, Panagiotis Issaris wrote:
> > 
> > A memset in the Sierra VMD audio & video decoder seems to be wrong. The
> > attached patch fixes this.
> > 
> > --- libavcodec/vmdav.c	(revision 5955)
> > +++ libavcodec/vmdav.c	(working copy)
> > @@ -92,7 +92,7 @@
> >      s += 4;
> > -    memset(queue, QUEUE_SIZE, 0x20);
> > +    memset(queue, 0x20, QUEUE_SIZE);
> 
> Looks correct to me.  Mike, Kostya?  Who's the maintainer of this file?
> 
> Diego
> 

Looks like it's not defined in MAINTAINERS either. As for me, apply it.

<offtopic>
I will be out for a few weeks so if something critical or trivial (like this patch)
occurs in my maintained files then apply it and I'll review everything after my return.
</offtopic>




More information about the ffmpeg-devel mailing list