[Ffmpeg-devel] [PATCH] '/nop' illegal for old versions of GAS
Wed Aug 9 11:38:54 CEST 2006
On Wed, Aug 09, 2006 at 11:45:29AM +1000, John Dalgliesh wrote:
> On Tue, 8 Aug 2006, Michael Niedermayer wrote:
> >On Wed, Aug 09, 2006 at 04:12:16AM +1000, John Dalgliesh wrote:
> >>On Mon, 7 Aug 2006, Michael Niedermayer wrote:
> >>>On Mon, Aug 07, 2006 at 10:33:31AM +1000, Nigel Pearson wrote:
> >>>> I assumed you wanted to keep the ability
> >>>>to pass in an opcode to do rounding?
> >>>yes, of course, the code must still work ...
> >>OK I think that there is a misunderstanding here. The only value ever
> >>passed into those IDCT macros is '/nop'. That is, the rounder argument is
> >>never used for anything except generating an assembler comment.
> >look again
> >[blah blah]
> >>Tested on linux x86 and compiles fine, does not cause any regressions to
> >>fail. (Two regressions fail for esoteric formats with svn head for me; the
> >>patch does not change this.)
> >of course it works on linux ...
> I thought that was the platform you were suggesting it wouldn't work on if
> the rounding ability were removed?
> Of course it fixes the problem on Mac OS X under x86 too. I didn't check
well, if thats the case then ive no objections to the patch
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel