[Ffmpeg-devel] Re: [PATCH] fix snow x86 SIMD

Michael Niedermayer michaelni
Thu Aug 10 09:19:04 CEST 2006


On Wed, Aug 09, 2006 at 10:11:34PM +0200, Martin von Gagern wrote:
> Hello.
> The previous two patches submitted by Luca Barbato were originally from
> me. Now I subscribed to the list myself, to accept the blame personally.
> Michael Niedermayer wrote:
> > sorry, no, every patch you submit gets dirtier then the previous, either
> > cleanly change the code or leave it
> OK, I tried another approach, and I believe it is cleaner from the
> register allocation perspective. It leaves all those register names to
> the compiler, by declaring them as "=&r" output parameters associated to
> otherwise unused variables. With optimization turned on, the values
> stored in those registers are discarded after the asm block and don't
> get written to the variables' memory location. With -fomit-frame-pointer
> alongside -fPIC, this compiles well enough, as the compiler uses %ebp.

does the code compile with gcc 3.4 & 2.95 on (32bit) x86 and do regression
tests pass on these?
if no then the patch is rejected, if yes ill review it more carefull

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list