[Ffmpeg-devel] [PATCH] (1) building with --disable-opts on i386 with mmx enabled

[Michael Niedermayer]

Hi

On Fri, Aug 11, 2006 at 07:54:31PM +0200, Marco Manfredini wrote:
> On Friday 11 August 2006 19:11, Michael Niedermayer wrote:
> 
> > ill leave this to our Makefile maintainer but my oppinion is rejected
> > as this 1. will break with some compilers and 2. doesnt belong to the
> > Makefile
> 
> The Makefile already assigns per file opcode extension flags. After my 
> addition it continues with: 
> 
> ifeq ($(TARGET_BUILTIN_VECTOR),yes)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> i386/fft_sse.o: CFLAGS+= -msse
> depend: CFLAGS+= -msse
> endif
> ifeq ($(TARGET_BUILTIN_3DNOW),yes)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[...]
> So it seems to belong in the Makefile and neither -m3dnow nor -msse have been 
> cause for concern regarding older compilers. 

no, see above, they are under ifeq ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is