[Ffmpeg-devel] [PATCH] Attempt image2 in watermark vhook

Guillaume POIRIER poirierg
Fri Aug 18 10:06:42 CEST 2006


On 8/18/06, V?ctor Paesa <wzrlpy at arsystel.com> wrote:
> Hi
> >
> > On Sun, Aug 13, 2006 at 09:18:08AM +0200, V?ctor Paesa wrote:
> >> Hi,
> >>
> >> Currently the watermark hook accepts GIF or movies, but it does not
> >> accept
> >> PNG or PNM as watermark images, since the move from image to image2 API.
> >>
> >> The attached patch just attempts "image2" if av_find_input_format is not
> >> able to find the proper format.
> >
> > patch probably ok
> >
> After five days with no negative comments probably next step would be to
> commit the patch, probably by the person listed in MAINTAINERS for
> vhook/watermark.c :-)

Could you please provide a sample commandline to test the behaviour of
FFmpeg with and without your code?

I'm not familiar with the watermak features of FFmpeg, so I'm not sure
how to test your patch before committing it (even though it's very
small, I just can't shovel every patch without some kind of testing,
be it just a compilation test on a different machine that the one of
the original dev)

A thing is not necessarily true because a man dies for it.
-- Oscar Wilde

More information about the ffmpeg-devel mailing list