[Ffmpeg-devel] [PATCH] Read AVI tags

Benjamin Larsson banan
Fri Aug 18 18:53:55 CEST 2006


Michael Niedermayer wrote:

>Hi
>
>On Wed, Aug 16, 2006 at 07:59:24PM -0400, David Conrad wrote:
>  
>
>> [...]
>>
>>>>+    end_tag(pb, list2);
>>>>+    list2 = start_tag(pb, "JUNK");
>>>>+    for (i = 0; i < 1016; i += 4)
>>>>+        put_le32(pb, 0);
>>>>+    end_tag(pb, list2);
>>>>        
>>>>
>>>what is that good for?
>>>      
>>>
>>It provides expansion space for editing tags without the need to  
>>rewrite the entire file. Most muxers give between one and two  
>>kilobytes for this.
>>
>>How does this version look?
>>    
>>
>
>looks mostly ok, somehow i dont like wasting a kb but well, i guess
>its not worth to make it optional ... so iam fine with the patch
>
>[...]
>
>  
>
Commited both the reading and writing. Checksums passed on amd64 box.

MvH
Benjamin Larsson

-- 
new tiny signature





More information about the ffmpeg-devel mailing list