[Ffmpeg-devel] [PATCH] MJPEG wrongly displayed with vertical YUV422
Mon Aug 21 11:42:07 CEST 2006
08/20/2006 08:08 PM, Michael Niedermayer wrote/a ?crit:
> On Sun, Aug 20, 2006 at 07:23:49PM +0200, Eric Piel wrote:
>> 05/08/2006 00:26 PM, Michael Niedermayer wrote/a ?crit:
>>> On Fri, Aug 04, 2006 at 06:15:24PM +0200, Eric Piel wrote:
>>>>> PIX_FMT_YUVJ422VP is unaceptable, it should be called PIX_FMT_YUVJ440P
>>>> Here is attached a corrected patch which fix the naming. Sorry, I had
>>>> tried to find the real naming but without success... those names are
>>>> quite a mess for me.
>>>>> and such vertical subsampled format can pretty much only occur
>>>>> if you rotate 4:2:2 video, should we really support that? what about
>>>>> rotated interlaced video?
>>>> Well, every tool which support JPEG seems to support this format, so why
>>>> not ffmpeg? IMHO, even if it is not so much used, the simple fact that
>>>> it allows to display lossless rotated video is worthy. Adding support
>>>> for it in ffmpeg is rather simple (especially since the patch is just
>>>> there ;-) ).
>>>> Please apply,
>>>> Index: libavutil/avutil.h
>>>> --- libavutil/avutil.h (r??vision 5924)
>>>> +++ libavutil/avutil.h (copie de travail)
>>>> @@ -53,6 +53,7 @@
>>>> PIX_FMT_RGB24, ///< Packed pixel, 3 bytes per pixel, RGBRGB...
>>>> PIX_FMT_BGR24, ///< Packed pixel, 3 bytes per pixel, BGRBGR...
>>>> PIX_FMT_YUV422P, ///< Planar YUV 4:2:2 (1 Cr & Cb sample per 2x1 Y
>>>> + PIX_FMT_YUV440P, ///< Planar YUV 4:4:0 (1 Cr & Cb sample per 1x2 Y
>>>> PIX_FMT_YUV444P, ///< Planar YUV 4:4:4 (1 Cr & Cb sample per 1x1 Y
>>> adding things into the middle of enums is not allowed, as it breaks binary
>> Ok, sorry I thought this file was only internal :-( So here is a new
>> version of the patch which add the definition at the end.
> but before PIX_FMT_NB (= pix format number)
Duh... I promise, I'm usually smarter than that ;-)
Ok here is a fixed version of the patch against latest svn.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2712 bytes
Desc: not available
More information about the ffmpeg-devel