[Ffmpeg-devel] [PATCH] AVISynth support

[Steve Lhomme]

Steve Lhomme wrote:
> M?ns Rullg?rd wrote:
>> Steve Lhomme said:
>>>
>>> M?ns Rullg?rd wrote:
>>>> Steve Lhomme said:
>>>>> Diego Biurrun wrote:
>>>>>> On Fri, Aug 18, 2006 at 04:18:28PM +0200, Steve Lhomme wrote:
>>>>>>> Here is the modified patch with all the fixes done.
>>>>>>>
>>>>>>> --- configure    (revision 6021)
>>>>>>> +++ configure    (working copy)
>>>>>>> @@ -1301,6 +1305,22 @@
>>>>>>>      restore_flags
>>>>>>>  fi
>>>>>>>
>>>>>>> +# Ugh, avisynth uses WINAPI calls. Generic tests won't work.
>>>>>>> +if enabled avisynth; then
>>>>>>> +#    save_flags
>>>>>>> +[...]
>>>>>>> +#    restore_flags
>>>>>> Why did you leave these two commented-out commands there?
>>>>> That's a mistake. Here is the modified patch.
>>>> The Makefile doesn't need any ifeq.
>>> Because the AVISynth code is surrounded by #if CONFIG_AVISYNTH ?
>>> If so yeah, that part can be dropped. As I wasn't sure which way is
>>> preferred, given it's a muxer but shouldn't be added by default...
>>
>> Neither the ifeq nor the #ifdef are needed.
> 
> OK, here is a patch without. Also with pkt->pts support and stream 
> discarding (very useful given the amount of data used).

So, was I right when assuming that even after cleaning the patch it will 
not be applied anyway ? (and Michael was wrong when assuming I would 
never clean/fix it).

Steve