[Ffmpeg-devel] MPEG-2 Acceleration Under Mac OS X - Can We Move This Forward?
Wed Aug 30 04:19:55 CEST 2006
Thanks for the quick review, John!
>> 2) Similarly with the ifs for runtime selection.
> But they are in a (more) inner loop.
Aah. Yes. Good point.
>> I think we also need to settle on one namespace.
>> Either DVDV or Accellent (at the moment there are both).
> I never used 'accellent' in my ffmpeg patch, someone else must have
> done that.
Probably me. The changes in MythTV go well beyond
just libavcodec (to configure, and all the calling code),
so I think the name crept in there as well, and then down
into the lib.
> Accellent is just the silly name of the demo app,
> DVDV(ideo) is the correct name for the acceleration method.
OK. I will start correcting this. Short is good.
> - Don't need two vars in the avctx, just have the pointer NULL if not
I wasn't sure if the DVDV stuff allowed multiple
clients (e.g. MythTV does PiP) so I wanted a variable
that could be incremented for each simultaneous client.
Nigel Pearson, nigel at ind.tansu.com.au|"Things you own
Telstra Net. Eng., Sydney, Australia | end up owning you"
Office: 9202 3900 Fax: 9261 3912 | Tyler,
Mobile: 0408 664435 Home: 9792 6998 | Fight Club
More information about the ffmpeg-devel